Fix bug with unwanted color in DrawLineModifer #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The bug is fixed and the tests are successful in the GitHub workflow, but for unknown reasons there is an error in the Docker test environment. docker-compose run --build --rm tests
[...]
There was 1 failure:
1) Intervention\Image\Tests\Unit\Drivers\Gd\Modifiers\DrawLineModifierTest::testApplyTransparent
Failed asserting that color rgba(255, 255, 255, 255) equals rgba(255, 129, 66, 255)
Failed asserting that an array contains 255.
/project/tests/BaseTestCase.php:79
/project/tests/Unit/Drivers/Gd/Modifiers/DrawLineModifierTest.php:36Could be related to GD Version This must be investigated before the fix can be merged. |
This test only fails with no longer supported GD lib version 2.1. The docker container of the test environment comes unfortunately with with version and I have not yet managed to install a more recent version. Unfortunately, adding the PHPUnit attribute #RequiresPhpExtension with version number does not work either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1347